Allow disabling AuthenticationProvider extension for workspace if not used by Settings Sync#320415
Conversation
… used by Settings Sync
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adjusts extension enablement validation and messaging so Settings Sync dependency on an authentication provider extension is handled more precisely (including in workspace scope).
Changes:
- Fixes/clarifies the error message when Settings Sync depends on an authentication provider extension.
- Narrows the “cannot change enablement in workspace” restriction to only block the auth provider extension currently used by Settings Sync.
gjsjohnmurray
left a comment
gjsjohnmurray
left a comment
There was a problem hiding this comment.
/assign @sandy081
|
@sandy081 please consider adding this to the 1.126 milestone. |
|
Thanks @gjsjohnmurray! Since the 1.126 endgame is already underway, I've added this to 1.127.0 so it gets proper review and bake time rather than rushing it in late. Appreciate the contribution! |
|
@sandy081 thanks. As soon as it's merged and showing up in Insiders I'll be happy to verify. |
|
@gjsjohnmurray I appended following change to the commit - also check for default account provider. I am really sorry that it took long for me to take this in. |
|
@sandy081 thanks for getting to it. Looks like a CI failure needs fixing though. |
dmitrivMS
left a comment
dmitrivMS
left a comment
There was a problem hiding this comment.
please address CI failures:
[09:37:58] src/vs/workbench/services/extensionManagement/test/browser/extensionEnablementService.test.ts(84,3): error TS2554: Expected 22 arguments, but got 21.
|
|
|
@gjsjohnmurray Fixed |
This PR fixes #269367